Doc: Mention what you can do with a control script early onTask-number: QTIFW-166
Change-Id: I42ff186b7f4203b6f29685d10136e25089892c4d
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@theqtcompany.com>
Fix maintenance tool upgrade on OSX.Before rename we need to delete a possible existing file,
otherwise it will fail and the installation is messed up.
Change-Id: I6ade434f828f11b38c00b52eabeb1c574557ec5a
Reviewed-by: Jonathan Courtois <jonathan.courtois@gmail.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
OS X: Make sure real user uid == euid in elevated modeThis fixes a bug that prevents changing existing .ini files
during an elevated installation.
QFileSystemEngine::fillMetaData() on Unix uses :access() to check
whether the user can write to a file, based on the real user id.
Because OS X's AuthorizationExecuteWithPrivileges() does keep the
original real user id also in the elevated process,
QFileInfo::isWritable() was returning false for existi...
Doc: Clarify use of addOperationMake it explicit that addOperation , addElevatedOperation should be
usually called from within createOperations().
Change-Id: Id14339b1259716825a9443cc563449025674976f
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Doc: Add a link to QInstaller::BinaryContent docs.And remove the ##TODO
Task-number: QTIFW-693
Change-Id: Idaef76e75ffef66b37fdd67e62f0760b7ec263c3
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Fix missing details output in example.Commit 17e29fc8d3 introduced a behavior change, the
installer.components is no longer a array property,
it is now a function returning an array. Update docs.
Change-Id: I4fcdee6cff4572012236e1ac0768013a1e5689ac
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Doc: update screenshots of Settings dialogThe Network tab changed, but I also updated
the Repositories tab screenshot for consistency.
Change-Id: Id6e0ffb6620449724da8093aae9816d4a02f7fe8
Task-number: QTIFW-708
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Doc: add docs for PackageManagerCoreMove the scripting API documentation to a separate
qdoc file. Where possible (no QDoc errors are generated),
only link from the C++ API documentation to the scripting
API documentation.
Change-Id: I969e9afc5cd45c495e6c517b825abb9a9aabdd82
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Fix help output for --proxyActually passing --proxy has an effect on Linux, but not on OS X.
Change-Id: I29a4d3945c6113d67311fdea3c700a5610075939
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Fix archivegen recursive include of directories with filter.Never pass recursive with true even if path is a directory,
otherwise the path containing the file name part of the path
is used as path to recurse and the actual file name is used
as filter.
For example: /path/to/doc -> Directory: /path/to -> Filter: doc
Task-number: QTIFW-639
Change-Id: I60972eab0b34073b4c81a815ee83058df09d1eab
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Reviewed-b...
Replace waitForBytesWritten with flushUnfortunately waitForByesWritten is known to fail from time to time:
QTBUG-24451 . We introduced it for making sure large data is actually
send, but flush() seems to serve the same purporse. The only drawback
is that flush() operates on the concrete socket, and therefore needs
to be called on the caller's side.
Change-Id: Ic92db298b3dad2c3f9eaa47d160aec517e33e284
Reviewed-by: Karsten Heimrich ...
Doc: link from gui C++ docs to scripting docsRemove duplicated text, where possible.
Change-Id: I6e5e81ab151817d76d53f7137e5183b12bdb04af
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Doc: link from C++ API ref to scripting API refRemove duplicated text where possible, and unify the
text if it is needed in both files (by QDoc).
Change-Id: If0c62a4a4abf6c1f61fd24f7947b9bc9bfb14f63
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Doc: Fix layout issues on the operations tableReplace a \code block with a monospace \c text, and unintended
'\n' sequences with spaces, allowing the text to span multiple
lines.
These changes make the table more readable by reducing its
width and avoiding the creation of a scrollbar.
Change-Id: Iff87fe2fe1b017e88395701643d278cb868e7f04
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Fix auto-test build with Qt 5.5.Still the tst_PackageManagerCore fails here cause the expected "\t"
is not expanded anymore by qDebug()...
Change-Id: Ia5f9383af6b32e95a198ce612c40fe0e3db2392d
Reviewed-by: Jarek Kobus <jaroslaw.kobus@theqtcompany.com>
Fix dubious warning about RequiresAdminRights tag.The tag was added once component script is parsed and we did
know that addElevatedOperation is called from script. However,
the initial commit 7ccd0acdcf35b957e9e7d04cd81902bac362ad04 did
not append the node to the parent package update node. Now we
decided to have the option statically and declarative available,
so we can remove the warning.
Task-number: QTIFW-670
Change-Id: I8cd8f702391d7bf8...
Don't modify check state of autodependent component when Select AllChange-Id: Id50fc5fa3460ffda62102019b46923b01b8e8745
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Enable logging categories as an installer option.Now by default all categories are disabled.
They get enabled only in verbose mode.
Verbose mode enables all categories by default.
Categories can be filtered using logging-rules option.
Change-Id: I9324826a6e2d7a746e3d7369747fcd31a42b84b6
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Add more explanations on warnings we issue.Change-Id: I7fea8d8c5ebc1ffea78635c335a0740c648b8e2e
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Add a missing warning about auto dependency on component with childrenChange-Id: Ib17fb2d48059ecc5b7f3b466661aad8e9d6b4b33
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Fix hang and errors when sending big packages over the socketThe assumption that packages of arbitrary size can be send is
apparently wrong on Windows. Also, one has sometimes to call
waitForBytesWritten, otherwise the data is never transferred.
Task-number: QTBUG-45625
Change-Id: I8b5a2584d4d42cf33d1d6688b0e17c44c325ac53
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
RemoteObject: Do not use processEvents()Replace the hand-written calls to processEvents() with
socket->waitForConnected(). It's unclear why this wasn't
done in the first place (maybe to keep the UI responsive
when the IFW was still single-threaded)? Anyhow, this
allows delivery of spurious events too, which can lead
to weird hang-ups.
Task-number: QTBUG-45625
Change-Id: I0ff2b85c05d0cc9d0102cf13791935be83c10536
Reviewed-by: Karsten ...
Fix "Too many open files" error.The current code did create all files in advance, exceeding the
open file limit on big downloads. Now we create the file once we
write to it.
Task-number: QTIFW-662
Change-Id: I9fe019e08342cbfb14bf564ad00b045cc03b6661
Reviewed-by: Jarek Kobus <jaroslaw.kobus@theqtcompany.com>
Make componentChecker warnings optional.To enable them export the following environment variable:
QT_LOGGING_RULES=ifw.componentChecker=true
Change-Id: Ied6744c745ca3fd0840c622c71a8ba30ad22e3d9
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Reset font property when setting "virtual" property to false.Visible in systeminfo example, when run with --show-virtual-components
Change-Id: Ie9f82602d86c9be8060bc14ef5b1e524387f5c17
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Doc: Remove mentioning of "UpdateAgent"It's the only place we mention an 'UpdateAgent' in the documentation/code.
Change-Id: I4e26246d7ecd7c9a81c006fb7448a9f788f7df20
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Fix compilation with gcc 4.6gcc 4.6 does not support alias templates yet.
Change-Id: I65f2dd8d8bf8ffae37ca2ed9743d24539cd47fcf
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Windows: Fix crashes in elevated installationUntil Qt 5.5.0, QLocalSocket::waitForReadyRead() immediately returns
when there are still bytesAvailable(). This means our busy loop for
polling new data gets stuck.
To work around this we've been explicitly calling processEvents(),
which however can have undesired side effects: Namely that non-network
events get delivered too, and that 'intermediate' requests are sent
to the server, resulting...
Do not throw on empty translation filesWorkaround for QTBUG-31031 (QTranslator::load returns false for
empty translation-files)
Change-Id: If4587b99c86a5afacada2d022af10460248ecf93
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Move the component checker after installer calculator.In this way we first check for errors, then check for warnings.
Change-Id: I3993498c9c517e7900d789fc0f04c59f9c150e14
Reviewed-by: Kai Koehne <kai.koehne@theqtcompany.com>
Document the operation storing mechanism more precisely.Task-number: QTIFW-669
Change-Id: I7b4a89f74c0e82ec091876effaedf304de345fbd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@theqtcompany.com>
Fix updatecheckCheck for installermarker was the wrong way around.
Change-Id: Id87cbc61d0bdb269eddc8377e5c775bc12c01174
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Doc: component.virtualStateChanged() signalDocs were missing from the scripting API docs.
Change-Id: I941e387c4226fae2a4640605299d925b3101bf46
Task-number: QTIFW-655
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Doc: AdminTargetDir element is Linux onlyIn the configuration.xml file.
Task-number: QTIFW-658
Change-Id: Ia83649aac14be1d24bc1aa1cfee27da4d335e63e
Reviewed-by: Karsten Heimrich <karsten.heimrich@theqtcompany.com>
Kai Koehne